Skip to content

Fix android ci#825

Merged
bors merged 2 commits into
rust-lang:masterfrom
malbarbo:android-fix-ci
Oct 28, 2017
Merged

Fix android ci#825
bors merged 2 commits into
rust-lang:masterfrom
malbarbo:android-fix-ci

Conversation

@malbarbo

Copy link
Copy Markdown
Contributor

No description provided.

@malbarbo

Copy link
Copy Markdown
Contributor Author

Tested locally (arm), let's see for the others archs.

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ p=1

Awesome, thanks so much!

@bors

bors commented Oct 27, 2017

Copy link
Copy Markdown
Contributor

📌 Commit a9115d5 has been approved by alexcrichton

bors added a commit that referenced this pull request Oct 27, 2017
@bors

bors commented Oct 27, 2017

Copy link
Copy Markdown
Contributor

⌛ Testing commit a9115d5 with merge 20758e5...

@bors

bors commented Oct 27, 2017

Copy link
Copy Markdown
Contributor

💔 Test failed - status-travis

@alexcrichton

Copy link
Copy Markdown
Member

@bors: retry

@bors

bors commented Oct 27, 2017

Copy link
Copy Markdown
Contributor

⌛ Testing commit a9115d5 with merge debbb73...

@bors

bors commented Oct 27, 2017

Copy link
Copy Markdown
Contributor

💔 Test failed - status-travis

@malbarbo

malbarbo commented Oct 27, 2017

Copy link
Copy Markdown
Contributor Author

I think the emulator for i686 does not run anymore without hardware acceleration...

qemu-system-i386: -device virtio-blk-pci,drive=system,iothread=disk-iothread,modern-pio-notify: ioeventfd is required for iothread
emulator: WARNING: encryption is off
emulator: WARNING: x86 emulation may not work without hardware acceleration!

I tried to run i686 tests like the x86_64 tests (without the emulator), but I get an error:

assertion failed: signal(libc::SIGPIPE, libc::SIG_IGN) != libc::SIG_ERR

The same I got when adding android testing support to cross. A partial solution was run the tests with qemu-i386, but it needs a patched qemu.

What we do now?

@alexcrichton

Copy link
Copy Markdown
Member

Hmm that's unfortunate :(

Is hardware acceleration something that needs lots of privs in the cloud? (Aka we will never be able to do this bare on Travis)

If so maybe we should just remove the tests for now?

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

Ok I've pushed a commit to disable it for now, but we can of course reenable if we can get it working again!

@bors

bors commented Oct 28, 2017

Copy link
Copy Markdown
Contributor

📌 Commit 8617317 has been approved by alexcrichton

@bors

bors commented Oct 28, 2017

Copy link
Copy Markdown
Contributor

⌛ Testing commit 8617317 with merge 70df7dc...

bors added a commit that referenced this pull request Oct 28, 2017
@bors

bors commented Oct 28, 2017

Copy link
Copy Markdown
Contributor

💔 Test failed - status-travis

@alexcrichton

Copy link
Copy Markdown
Member

@bors: retry

bors added a commit that referenced this pull request Oct 28, 2017
@bors

bors commented Oct 28, 2017

Copy link
Copy Markdown
Contributor

⌛ Testing commit 8617317 with merge 93a11fd...

@bors

bors commented Oct 28, 2017

Copy link
Copy Markdown
Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 93a11fd to master...

@bors bors merged commit 8617317 into rust-lang:master Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants