Skip to content

Add contents of linux/can/bcm.h#4683

Merged
tgross35 merged 1 commit into
rust-lang:mainfrom
coolreader18:can_bcm
Oct 22, 2025
Merged

Add contents of linux/can/bcm.h#4683
tgross35 merged 1 commit into
rust-lang:mainfrom
coolreader18:can_bcm

Conversation

@coolreader18

Copy link
Copy Markdown
Contributor

Description

There's already can::{raw, j1939}, and this adds bcm.

Sources

https://github.com/torvalds/linux/blob/b320789d6883cc00ac78ce83bccbfe7ed58afcf0/include/uapi/linux/can/bcm.h

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot label +stable-nominated

@rustbot rustbot added O-linux S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Sep 1, 2025
Comment thread src/new/linux_uapi/linux/can/bcm.rs Outdated
@coolreader18

Copy link
Copy Markdown
Contributor Author

@rustbot label -S-waiting-on-author +S-waiting-on-review

@tgross35

Copy link
Copy Markdown
Contributor

Hey, sorry for the delay here. I wanted to require making it explicit that the enum should be anonymous, so I just went ahead and merged that in 02c4d66. Would you be able to update using #anon?

@rustbot author

@rustbot

rustbot commented Oct 22, 2025

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Comment thread src/new/linux_uapi/linux/can/bcm.rs
@rustbot

rustbot commented Oct 22, 2025

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@coolreader18

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@tgross35 tgross35 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but LGTM. Could you please squash the commits?

Comment thread libc-test/build.rs Outdated
@tgross35

Copy link
Copy Markdown
Contributor

Thank you!

@tgross35 tgross35 enabled auto-merge October 22, 2025 20:05
@tgross35 tgross35 added this pull request to the merge queue Oct 22, 2025
Merged via the queue into rust-lang:main with commit 62a1fad Oct 22, 2025
76 of 79 checks passed
@coolreader18 coolreader18 deleted the can_bcm branch October 22, 2025 21:01
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
(backport <rust-lang#4683>)
(cherry picked from commit 62a1fad)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
(backport <rust-lang#4683>)
(cherry picked from commit 62a1fad)
@tgross35 tgross35 mentioned this pull request Nov 3, 2025
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 3, 2025
(backport <rust-lang#4683>)
(cherry picked from commit 62a1fad)
github-merge-queue Bot pushed a commit that referenced this pull request Nov 4, 2025
(backport <#4683>)
(cherry picked from commit 62a1fad)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-linux stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants