Clarify that optimization level 1#9020
Conversation
It _also_ turns on debug_assertions. (I was confused by this)
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Thanks for the PR! I don't think this is quite correct, though I see how it is confusing. In Cargo, debug-assertions are always driven by the profile (it doesn't have any default behavior based on the opt-level), and the profile has hard-coded defaults for things like debug-assertions. I think when I wrote this, I probably forgot that and just copied the behavior as that is how I think the correct fix here is to just remove the note |
|
I just filed a PR to update the language as you suggested, @ehuss. |
Remove statement that opt-level 0 turns on debug See #9020 (comment)
It also turns on debug_assertions.
(I was confused by this)