Skip to content

Fix cargo install using a workspace target dir#5685

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:fix-cargo-install-target-dir
Jul 5, 2018
Merged

Fix cargo install using a workspace target dir#5685
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:fix-cargo-install-target-dir

Conversation

@alexcrichton

Copy link
Copy Markdown
Member

Closes #5662

@rust-highfive

Copy link
Copy Markdown

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@matklad

matklad commented Jul 5, 2018

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jul 5, 2018

Copy link
Copy Markdown
Contributor

📌 Commit d1ef031 has been approved by matklad

@bors

bors commented Jul 5, 2018

Copy link
Copy Markdown
Contributor

⌛ Testing commit d1ef031 with merge ebeed97...

bors added a commit that referenced this pull request Jul 5, 2018
…tklad

Fix `cargo install` using a workspace target dir

Closes #5662
@bors

bors commented Jul 5, 2018

Copy link
Copy Markdown
Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing ebeed97 to master...

@bors bors merged commit d1ef031 into rust-lang:master Jul 5, 2018
@Keruspe

Keruspe commented Jul 5, 2018

Copy link
Copy Markdown
Contributor

@alexcrichton if 1.27.1 happens, would this be a good candidate for a backport? This breaks packaging crates using workspaces in sandboxes environments

@alexcrichton alexcrichton deleted the fix-cargo-install-target-dir branch July 5, 2018 19:54
@alexcrichton

Copy link
Copy Markdown
Member Author

I think for the stable point release it's a bit too close, but we can certainly backport this to beta

bors added a commit that referenced this pull request Jul 5, 2018
[beta] Fix `cargo install` using a workspace target dir

Backport of #5685
@ehuss ehuss modified the milestones: 1.29.0, 1.28.0 Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cargo install doesn't follow workspace target

6 participants