Ignore panic configuration for test/bench profiles#3175
Conversation
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
ping r? @brson |
|
☔ The latest upstream changes (presumably #3242) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
force-pushed
the
bench-abort
branch
from
3e81fde to
4a73741
Compare
Both of these profiles link to libtest, so it's invalid to configure them with `panic="abort"`. To prevent confusing errors just ignore the configuration for now. Closes rust-lang#3166
alexcrichton
force-pushed
the
bench-abort
branch
from
4a73741 to
0f44202
Compare
|
@bors r+ |
|
📌 Commit 0f44202 has been approved by |
Ignore `panic` configuration for test/bench profiles Both of these profiles link to libtest, so it's invalid to configure them with `panic="abort"`. To prevent confusing errors just ignore the configuration for now. Closes #3166
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
|
@alexcrichton In light of I just tried this and was surprised to get |
|
@alecmocatta this PR is nearly two years old and is, uh, very far out of cache. Perhaps a new issue could be opened? |
6 participants
Both of these profiles link to libtest, so it's invalid to configure them with
panic="abort". To prevent confusing errors just ignore the configuration fornow.
Closes #3166