Switch testsuite to use GNU tar headers#16774
Closed
ehuss wants to merge 1 commit into
Closed
Conversation
This updates the testsuite's publishing code to use GNU tar headers instead of USTAR. We are having problems with the new `symlink_and_directory` test in rust-lang/rust because the target directory is longer than typical, and it is causing a failure. USTAR symlink entries are restricted to 100 bytes long. GNU is capable of using the `@LongLink` extension which does not have a limit. Cargo's own publishing code was switched to GNU in Rust 1.46 (2020) via rust-lang#8453. I double checked the old tar 0.4.44, and the test fails as expected.
rustbot
added
A-testing-cargo-itself
Collaborator
|
r? @epage rustbot has assigned @epage. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
Well, this isn't going to work since the package files change based on the directory length. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the testsuite's publishing code to use GNU tar headers instead of USTAR. We are having problems with the new
symlink_and_directorytest in rust-lang/rust because the target directory is longer than typical, and it is causing a failure. USTAR symlink entries are restricted to 100 bytes long. GNU is capable of using the@LongLinkextension which does not have a limit.Cargo's own publishing code was switched to GNU in Rust 1.46 (2020) via #8453.
I double checked the old tar 0.4.44, and the test fails as expected.