Skip to content

fix(new): Dont say were adding to a workspace when a regular package is in root#13987

Merged
bors merged 1 commit into
rust-lang:masterfrom
epage:new
May 31, 2024
Merged

fix(new): Dont say were adding to a workspace when a regular package is in root#13987
bors merged 1 commit into
rust-lang:masterfrom
epage:new

Conversation

@epage

@epage epage commented May 30, 2024

Copy link
Copy Markdown
Contributor

Fixes #13985

@rustbot

rustbot commented May 30, 2024

Copy link
Copy Markdown
Collaborator

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added Command-new S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2024
@linyihai

Copy link
Copy Markdown
Contributor

Looks good for me, thank you for update.

@ehuss

ehuss commented May 31, 2024

Copy link
Copy Markdown
Contributor

Thanks!

@bors r+

@bors

bors commented May 31, 2024

Copy link
Copy Markdown
Contributor

📌 Commit 26c1678 has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2024
@bors

bors commented May 31, 2024

Copy link
Copy Markdown
Contributor

⌛ Testing commit 26c1678 with merge d04355a...

@bors

bors commented May 31, 2024

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing d04355a to master...

@bors bors merged commit d04355a into rust-lang:master May 31, 2024
@epage epage deleted the new branch May 31, 2024 18:14
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 1, 2024
Update cargo

9 commits in 431db31d0dbeda320caf8ef8535ea48eb3093407..7a6fad0984d28c8330974636972aa296b67c4513
2024-05-28 18:17:31 +0000 to 2024-05-31 22:26:03 +0000
- fix(config): Ensure `--config net.git-fetch-with-cli=true` is respected (rust-lang/cargo#13992)
- Fix libcurl proxy documentation link (rust-lang/cargo#13990)
- fix(new): Dont say were adding to a workspace when a regular package is in root (rust-lang/cargo#13987)
- fix: adjust custom err from cert-check due to libgit2 1.8 change (rust-lang/cargo#13970)
- fix(toml): Ensure targets are in a deterministic order (rust-lang/cargo#13989)
- doc(cargo-package): explain no guarantee of vcs provenance (rust-lang/cargo#13984)
- chore: fix some comments (rust-lang/cargo#13982)
- feat: stabilize `cargo update --precise <yanked>` (rust-lang/cargo#13974)
- Update openssl-src to 111.28.2+1.1.1w (rust-lang/cargo#13976)

r? ghost
@rustbot rustbot added this to the 1.80.0 milestone Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Command-new S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cargo new: Confusing error message about adding to a workspace

5 participants