Skip to content

Remove wrong url in benchsuite manifest.#12020

Merged
bors merged 1 commit into
rust-lang:masterfrom
ehuss:benchmark-wrong-doc
Apr 24, 2023
Merged

Remove wrong url in benchsuite manifest.#12020
bors merged 1 commit into
rust-lang:masterfrom
ehuss:benchmark-wrong-doc

Conversation

@ehuss

@ehuss ehuss commented Apr 23, 2023

Copy link
Copy Markdown
Contributor

This was a copy-paste error when it was added. The documentation field isn't too important here since this is never published.

@rustbot

rustbot commented Apr 23, 2023

Copy link
Copy Markdown
Collaborator

r? @weihanglo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testing-cargo-itself Area: cargo's tests S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2023

@0xPoe 0xPoe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM. Thanks!

Comment thread cargo-crypto-hash Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we add this file?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I probably just fat-fingered something. Thanks for pointing it out!

@ehuss ehuss force-pushed the benchmark-wrong-doc branch from a154820 to 7344045 Compare April 24, 2023 02:01

@0xPoe 0xPoe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@weihanglo

Copy link
Copy Markdown
Member

Thanks you all

@bors r=hi-rustin

@bors

bors commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

📌 Commit 7344045 has been approved by hi-rustin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2023
@bors

bors commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

⌛ Testing commit 7344045 with merge 39a972d...

@bors

bors commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions
Approved by: hi-rustin
Pushing 39a972d to master...

@bors bors merged commit 39a972d into rust-lang:master Apr 24, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 26, 2023
Update cargo

17 commits in de80432f04da61d98dcbbc1572598071718ccfd2..9e586fbd8b931494067144623b76c37d213b1ab6
2023-04-21 13:18:32 +0000 to 2023-04-25 22:09:11 +0000
- Update home dependency (rust-lang/cargo#12037)
- Warn instead of error in `cargo package` on empty `readme` or `license-file` in manifest (rust-lang/cargo#12036)
- Clarify documentation around test target setting. (rust-lang/cargo#12032)
- fix: apply `[env]` to target info discovery rustc (rust-lang/cargo#12029)
- CI: ensure intra links for all members are checked (rust-lang/cargo#12025)
- chore: make credential dependencies platform-specific (rust-lang/cargo#12027)
- CI: use `-p` to specify workspace members instead of `--manifest-path` (rust-lang/cargo#12024)
- ci: requires `test_gitoxide` and `lockfile` for both bors success and failure (rust-lang/cargo#12026)
- Update windows-sys (rust-lang/cargo#12021)
- Bump libc to 0.2.142 (rust-lang/cargo#12014)
- Update openssl-src to 111.25.3+1.1.1t (rust-lang/cargo#12005)
- Improve error message for empty dep (rust-lang/cargo#12001)
- Remove wrong url in benchsuite manifest. (rust-lang/cargo#12020)
- Bump versions of local crates (rust-lang/cargo#12019)
- Add the Win32_System_Console feature since it is used (rust-lang/cargo#12016)
- Update outdated crates.io URLs in publishing guide (rust-lang/cargo#12018)
- Allow named debuginfo options in Cargo.toml (rust-lang/cargo#11958)

r? `@ghost`
@ehuss ehuss added this to the 1.71.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testing-cargo-itself Area: cargo's tests S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants