Skip to content

misc: Use 'and' joined summary for install/uninstall#11925

Closed
kamilogorek wants to merge 1 commit into
rust-lang:masterfrom
kamilogorek:and-joined-install-summary
Closed

misc: Use 'and' joined summary for install/uninstall#11925
kamilogorek wants to merge 1 commit into
rust-lang:masterfrom
kamilogorek:and-joined-install-summary

Conversation

@kamilogorek

Copy link
Copy Markdown

It's a cosmetic change, that modifies how installed/uninstalled crates are listed. When precisely two are installed, it just reads oddly right now IMO.

Note that https://crates.io/crates/and crate is reserved, so there will never be something and and.

A: Summary Successfully installed tauri-cli, trunk!
B: Summary Successfully installed tauri-cli and trunk!
A: Summary Successfully installed tauri, tauri-cli, trunk!
B: Summary Successfully installed tauri, tauri-cli and trunk!

@rustbot

rustbot commented Apr 2, 2023

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @epage (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added Command-install Command-uninstall S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2023
[INSTALLING] [CWD]/home/.cargo/bin/baz[EXE]
[INSTALLED] package `baz v1.0.0` (executable `baz[EXE]`)
[SUMMARY] Successfully installed foo, bar, baz!
[SUMMARY] Successfully installed foo, bar and baz!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the test output, I feel like using and makes it harder to quickly scan. Using an oxford comma would help but that doesn't help with the foo and bar (2 item) case.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, makes perfect sense, as it's subjective. I'm fine closing the PR, so no worries :)

@bors

bors commented Apr 8, 2023

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #11866) made this pull request unmergeable. Please resolve the merge conflicts.

@weihanglo

Copy link
Copy Markdown
Member

Hey! Thanks for the pull request. By following the discussion above, I'll go ahead and close this. I appreciate the effort making the output more correct. Thanks!

@weihanglo weihanglo closed this Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Command-install Command-uninstall S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants