misc: Use 'and' joined summary for install/uninstall#11925
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @epage (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
| [INSTALLING] [CWD]/home/.cargo/bin/baz[EXE] | ||
| [INSTALLED] package `baz v1.0.0` (executable `baz[EXE]`) | ||
| [SUMMARY] Successfully installed foo, bar, baz! | ||
| [SUMMARY] Successfully installed foo, bar and baz! |
There was a problem hiding this comment.
Looking at the test output, I feel like using and makes it harder to quickly scan. Using an oxford comma would help but that doesn't help with the foo and bar (2 item) case.
There was a problem hiding this comment.
Gotcha, makes perfect sense, as it's subjective. I'm fine closing the PR, so no worries :)
|
☔ The latest upstream changes (presumably #11866) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Hey! Thanks for the pull request. By following the discussion above, I'll go ahead and close this. I appreciate the effort making the output more correct. Thanks! |
It's a cosmetic change, that modifies how installed/uninstalled crates are listed. When precisely two are installed, it just reads oddly right now IMO.
Note that https://crates.io/crates/and crate is reserved, so there will never be
something and and.