[beta 1.69] Backport #11881 Add delays to network retries.#11922
Conversation
|
r? @epage (rustbot has picked a reviewer for you, use r? to override) |
|
rustbot
added
A-documenting-cargo-itself
|
@rust-lang/cargo This is a proposal for a beta backport. I'm not entirely confident backporting this is a good idea, since networking code is generally delicate, and this has risk that it will introduce some regressions. It is also a fairly large amount of code. However, I worry about potential caching issues with the sparse rollout (though there has only been one report of an issue). The change should land in nightly tomorrow, so at least it will git a little bit of testing there. Let me know whether or not you think we should move forward with this backport. |
Due to an update in the output from the latest clap, these tests no longer pass. I think these aren't likely to have any regressions on beta or stable, so they are just disabled for now.
…=weihanglo Disable test_profile test on windows-gnu This disables the `test_profile` test on windows-gnu due to a regression in nightly, see rust-lang/rust#109797.
epage
left a comment
epage
left a comment
There was a problem hiding this comment.
Ok with merging this if we agree to the backport
weihanglo
left a comment
weihanglo
left a comment
There was a problem hiding this comment.
Seems good to me, thanks!
If we want to backport this, it should be done as early as possible.
|
Let's discuss the beta backports at today's meeting. |
|
Discussed in the meeting, and decided not to backport due to the complexity of the change, and that the default isn't changing until 1.70 (which I was mistaken about). |
5 participants
This is a backport of #11881 to beta. The intent is to help mitigate any potential issues that might crop up with turning sparse index on by default.
This also includes some other changes to get CI passing: