Fix 20.1 Miri unsafe code section#4401
Closed
abemassry wants to merge 1 commit into
Closed
Conversation
Fixes rust-lang#4338 Wrong concept in subsection "Using Miri to check unsafe code" of section "20.1. Unsafe Rust" This is a followup to PR rust-lang#4062 This PR adds a working example of using Miri where the code will compile and run without warnings or errors, but with undefined behavior while it runs. After running it through Miri though it correctly identifies the data race. Feedback welcome on matching the text to the books style. Or if anyone wants to collaborate on other examples of Miri output.
|
Thank you for creating this pull request. I just read this section and was confused by the |
Member
|
Thanks! However, we decided to fix this a different way in 6032617. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4338 Wrong concept in subsection "Using Miri to check unsafe code" of section "20.1. Unsafe Rust"
This is a followup to PR #4062
This PR adds a working example of using Miri where the code will compile and run without warnings or errors, but with undefined behavior while it runs. After running it through Miri though it correctly identifies the data race.
Feedback welcome on matching the text to the books style. Or if anyone wants to collaborate on other examples of Miri output.