Skip to content

Implement flickity#55

Merged
meg-gutshall merged 7 commits into
rubyforgood:mainfrom
grazirs:implement-flickity
Aug 20, 2022
Merged

Implement flickity#55
meg-gutshall merged 7 commits into
rubyforgood:mainfrom
grazirs:implement-flickity

Conversation

@grazirs
Copy link
Copy Markdown
Contributor

@grazirs grazirs commented Aug 10, 2022

What github issue is this PR for, if any?
Resolves #54

What changed, and why?

  • Now, all the sliders on the website use the Flickity library instead of OwlCarousel2 and Slick libraries.
  • Also, I fixed the text animations in the home page slider.

Sliders:

  • The hero slider on the home page
  • The supporters slider on the home page
  • The testimonial slider (not currently rendered on the site, but you can find an example here)
  • The project slider (not currently rendered on the site -->example:)
  • Clean up main.js
    Hero slider and supporter slider, you can see here, the last two are not rendered on the site yet.
sliders-1.mov

@meg-gutshall
Copy link
Copy Markdown
Member

This looks great! Your code is super clean as well!

One change request and then I'll merge it in. Can you slow down the speed of the sliders? The main one we had at 20000ms and the supporters at 5000ms.

@meg-gutshall
Copy link
Copy Markdown
Member

@meg-gutshall meg-gutshall merged commit b73c4ac into rubyforgood:main Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Flickity throughout Site

2 participants