Fix class/module alias document having wrong name#1515
Merged
tompng merged 1 commit intoruby:masterfrom Dec 21, 2025
Merged
Conversation
Collaborator
|
🚀 Preview deployment available at: https://fdc86876.rdoc-6cd.pages.dev (commit: dc4d1a1) |
4e58ee5 to
cb5203f
Compare
st0012
reviewed
Dec 20, 2025
| assert_equal [@klass_alias, @ignored, @klass, @object], | ||
| assert_equal %w[Ignored Klass Klass::A Object], | ||
| [@ignored, @klass, @klass_alias, @object].map(&:full_name) | ||
| assert_equal [@ignored, @klass, @klass_alias, @object], |
Member
There was a problem hiding this comment.
Can you add one of these tests to Aliki’s generator test as well?
st0012
reviewed
Dec 20, 2025
| cm_alias.parent = self | ||
| cm_alias.full_name = nil # force update for new parent | ||
| end | ||
| cm_alias.full_name = nil # force update for new parent |
Member
There was a problem hiding this comment.
Can we have a ClassModule/CodeObject level test to prevent regression too?
Stop aliased class/module document file overwrite original one. Fix aliasing-to-toplevel check.
cb5203f to
dc4d1a1
Compare
st0012
approved these changes
Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1014
Some aliased class/module document had wrong title.
Example: https://docs.ruby-lang.org/en/master/Net/HTTP.html
Title should be
class Net::HTTP, Notclass Net::HTTPSession.RDoc first generates
Net/HTTP.htmlwith the correct content, and then overwrite the same file with aliased-name content.Fixes:
Documents of
ruby/rubythat will change: