Conversation
Collaborator
|
🚀 Preview deployment available at: https://3aedfc70.rdoc-6cd.pages.dev (commit: d461adf) |
st0012
force-pushed
the
fix-search-modal
branch
from
823a0b2 to
fdddc9f
Compare
st0012
changed the title
tompng
reviewed
Dec 21, 2025
| // Hide search results when clicking outside the search area | ||
| document.addEventListener('click', (e) => { | ||
| if (!e.target.closest('.navbar-search-desktop')) { | ||
| result.setAttribute('aria-expanded', 'false'); |
Member
There was a problem hiding this comment.
Up and down arrow keys still moves in the hidden search navigation.
I think search.setNavigationActive(false) search.setNavigationActive(true) are needed where changing aria-expanded attribute.
Adding search.hide() and search.show() that does both might be a good idea.
tompng
reviewed
Dec 21, 2025
| # RDoc version you are using | ||
|
|
||
| VERSION = '7.0.1' | ||
| VERSION = '7.0.2' |
Member
There was a problem hiding this comment.
Maybe wrong commit pushed?
I'm fine cutting 7.0.2
Member
Author
There was a problem hiding this comment.
No I just thought if we could merge the PR we can ship it immediately in 7.0.2 😛
This would still work tho. I'd love to cut a new release right after this is merged.
st0012
force-pushed
the
fix-search-modal
branch
from
7ad4bbb to
5d2565b
Compare
After this change: | Scenario | Behavior | |----------|----------| | Type search, click result | Navigate without `?q=`, clean URL without dropdown | | Type search, press Enter | Navigate without `?q=`, clean URL without dropdown | | Land on URL with `?q=` param | Show dropdown with pre-filled query | | Click outside dropdown | Hide dropdown, keep input value | | Focus input with existing query | Show dropdown again |
st0012
force-pushed
the
fix-search-modal
branch
from
5d2565b to
d461adf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this change:
?q=, clean URL without dropdown?q=, clean URL without dropdown?q=param