Skip to content

Add version query string to Aliki assets for cache busting#1476

Merged
st0012 merged 2 commits intomasterfrom
bust-asset-caching
Nov 28, 2025
Merged

Add version query string to Aliki assets for cache busting#1476
st0012 merged 2 commits intomasterfrom
bust-asset-caching

Conversation

@st0012
Copy link
Copy Markdown
Member

@st0012 st0012 commented Nov 27, 2025

No description provided.

@matzbot
Copy link
Copy Markdown
Collaborator

matzbot commented Nov 27, 2025

🚀 Preview deployment available at: https://5fcbdf33.rdoc-6cd.pages.dev (commit: 4a9a669)

Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@st0012 st0012 force-pushed the bust-asset-caching branch from d363bd8 to 13775fa Compare November 28, 2025 01:24
<link
href="<%= h asset_rel_prefix %>/<%= h File.basename stylesheet %>?v=<%= h RDoc::VERSION %>"
rel="stylesheet"
>
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These styling change is suggested by Herb. I personally feel fine with them but am open to apply custom rules later if anyone has any strong opinion.

Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@st0012 st0012 merged commit 6079cda into master Nov 28, 2025
62 checks passed
@st0012 st0012 deleted the bust-asset-caching branch November 28, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants