add custom event thrown#212
Closed
trtrtr6 wants to merge 2 commits intorrweb-io:masterfrom
Closed
Conversation
Member
|
#219 implemented this, thanks |
Alexays
pushed a commit
to ScreebApp/rrweb
that referenced
this pull request
Dec 11, 2025
This fixes a bug with blocking iframes that are dynamically added to the DOM after the snapshot is taken. This ensures we check if iframe is considered blocked before adding to iframe manager. Closes getsentry/sentry-javascript#13173
GabriWar
pushed a commit
to GabriWar/rrweb
that referenced
this pull request
May 7, 2026
## Summary - Bumps `markdownlint-cli` from `^0.31.1` to `^0.48.0` - Also bumps `markdownlint` lib from `^0.25.1` to `^0.40.0` to match - Replaces `glob` with `tinyglobby` (no more vulnerable glob dep) - Uses `minimatch@10.2.5` (patched, replaces vulnerable 10.0.3) ## Breaking changes in markdownlint-cli 0.31 -> 0.48 - **Node.js >=20 required** (was >=12) — we use Node 20, not affected - **`glob` replaced by `tinyglobby`** — internal dep swap, CLI interface unchanged, not affected - **`markdownlint` lib 0.25 -> 0.40** — internal engine upgrade, switched to `markdown-it` parser. Some rules renamed/added. We only run `markdownlint docs` with default config, existing warnings are pre-existing, not affected - **New/updated lint rules** — some rules added or tightened across versions. Output now labels findings as "error" instead of bare rule names. Cosmetic only, not affected - **Config format additions** (TOML support added) — our config is unchanged, not affected ## Dependabot alerts resolved - Resolves glob command injection (high) — `glob` removed entirely, replaced by `tinyglobby` - Resolves minimatch ReDoS alerts via `minimatch@10.2.5`: [rrweb-io#213](https://github.com/getsentry/rrweb/security/dependabot/213), [rrweb-io#212](https://github.com/getsentry/rrweb/security/dependabot/212), [rrweb-io#208](https://github.com/getsentry/rrweb/security/dependabot/208), [rrweb-io#201](https://github.com/getsentry/rrweb/security/dependabot/201) - Partially resolves brace-expansion alerts: [rrweb-io#238](https://github.com/getsentry/rrweb/security/dependabot/238), [rrweb-io#134](https://github.com/getsentry/rrweb/security/dependabot/134) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
之前是监听event-cast 来获取 custom event 进行处理，后面发现 event-cast 在chrome 设置 disable cache的情况下，监听到的event-cast有丢失（原因未知），故添加对 custom 事件专门监听 custom event