[hist] Exception safety in RHistStats, test for RHist#21687
Open
hahnjo wants to merge 4 commits intoroot-project:masterfrom
Open
[hist] Exception safety in RHistStats, test for RHist#21687hahnjo wants to merge 4 commits intoroot-project:masterfrom
RHistStats, test for RHist#21687hahnjo wants to merge 4 commits intoroot-project:masterfrom
Conversation
First check all arguments before modifying the object.
This does not require code changes because RHistEngine::Fill is more strict (via RAxes::ComputeGlobalIndex) than RHistStats::Fill, and the RHist constructor disables dimensions with a categorical axis.
First check all dimensions before modifying the object.
This does not require code changes because RHistEngine::Add ensures an identical axis configuration, which is more strict than the checks in RHistStats::Add.
Test Results 22 files 22 suites 3d 6h 9m 54s ⏱️ Results for commit 73053cb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For exception safety, first perform all checks before modifying the object.