Record alignment of class in dictionary and use in TStreamerInfo#21669
Open
pcanal wants to merge 7 commits intoroot-project:masterfrom
Open
Record alignment of class in dictionary and use in TStreamerInfo#21669pcanal wants to merge 7 commits intoroot-project:masterfrom
pcanal wants to merge 7 commits intoroot-project:masterfrom
Conversation
silverweed
reviewed
Mar 24, 2026
Test Results 20 files 20 suites 2d 22h 43m 27s ⏱️ For more details on these failures, see this check. Results for commit ec7c978. ♻️ This comment has been updated with latest results. |
Since align is a power of 2 the modulo may be written as (offset & (align - 1)) (assuming offset is non-negative) Co-authored-by: silverweed <giacomo.parolini@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #21667 and thus addresses CMS issue seen at github.com/cms-sw/cmssw/pull/49969