Skip to content

Move generating AST log to when a module is actually being parsed. #8210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nojaf merged 3 commits into from
Jan 21, 2026
Merged

Move generating AST log to when a module is actually being parsed. #8210

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f463385
Move generating AST log to when a module is actually being parsed.
nojaf Jan 21, 2026
e577790
Add changelog
nojaf Jan 21, 2026
f745d46
Merge branch 'master' into only-log-ast-when-dirty
nojaf Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@

#### :nail_care: Polish

- Build system: Only log verbose "Generating AST for module" when actually parsing. https://github.com/rescript-lang/rescript/pull/8210

#### :house: Internal

# 12.1.0
Expand Down
2 changes: 1 addition & 1 deletion rewatch/src/build/parse.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ pub fn generate_asts(
.modules
.par_iter()
.map(|(module_name, module)| {
debug!("Generating AST for module: {module_name}");
let package = build_state
.get_package(&module.package_name)
.expect("Package not found");
Expand All @@ -47,6 +46,7 @@ pub fn generate_asts(
.map(|i| i.parse_dirty)
.unwrap_or(false)
{
debug!("Generating AST for module: {module_name}");
inc();
let ast_result = generate_ast(
package.to_owned(),
Expand Down
Loading