Skip to content

fix: should format max/min with precision#385

Merged
afc163 merged 1 commit into
react-component:masterfrom
boomler:wangao-fix-max-min-precision
Dec 6, 2021
Merged

fix: should format max/min with precision#385
afc163 merged 1 commit into
react-component:masterfrom
boomler:wangao-fix-max-min-precision

Conversation

@boomler
Copy link
Copy Markdown
Contributor

@boomler boomler commented Dec 5, 2021

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/input-number/4LByPTMFwV6AC6xUvS7MEUw4fJpK
✅ Preview: https://input-number-git-fork-boomler-wangao-fix-86ab6b-react-component.vercel.app

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 6, 2021

Codecov Report

Merging #385 (79438cd) into master (d65b0dc) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
+ Coverage   97.67%   97.76%   +0.09%     
==========================================
  Files           9        9              
  Lines         430      448      +18     
  Branches      115      116       +1     
==========================================
+ Hits          420      438      +18     
  Misses         10       10              
Impacted Files Coverage Δ
src/InputNumber.tsx 98.40% <100.00%> (+0.07%) ⬆️
src/utils/MiniDecimal.ts 96.40% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d65b0dc...79438cd. Read the comment docs.

@afc163 afc163 merged commit d3de147 into react-component:master Dec 6, 2021
@tangjinzhou
Copy link
Copy Markdown

@boomler
when we set min={1} max={10} precision={0}, we can not input min value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[input-number] get an invalid value when max's precision don't match component's precision

3 participants