This repository was archived by the owner on Apr 10, 2022. It is now read-only.
reword split() definition to get around the virtual subclass issue#29
Merged
iritkatriel merged 1 commit intomasterfrom Feb 16, 2021
Merged
reword split() definition to get around the virtual subclass issue#29iritkatriel merged 1 commit intomasterfrom
iritkatriel merged 1 commit intomasterfrom
Conversation
gvanrossum
approved these changes
Feb 16, 2021
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
I like the new wording. And I suppose the "virtual subclass issue" is about the use (or not) of __instancecheck__?
Member
Author
Yes, following this discussion: iritkatriel/cpython#7 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.