Skip to content

bpo-31201: Clarify command to re-run failing test(s) with example#6417

Merged
ned-deily merged 2 commits intopython:masterfrom
aaronang:bpo-31201
Apr 9, 2018
Merged

bpo-31201: Clarify command to re-run failing test(s) with example#6417
ned-deily merged 2 commits intopython:masterfrom
aaronang:bpo-31201

Conversation

@aaronang
Copy link
Copy Markdown
Contributor

@aaronang aaronang commented Apr 8, 2018 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Apr 8, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

ned-deily
ned-deily requested changes Apr 8, 2018
View reviewed changes
README.rst Outdated
example, if ``test_os`` and ``test_gdb`` failed, you can run::

make test TESTOPTS="-v test_that_failed"
make test TESTOPTS="-v test_os test_gdb"
Copy link
Copy Markdown
Member

@ned-deily ned-deily Apr 8, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the (additional) preceding space?

Copy link
Copy Markdown
Contributor Author

@aaronang aaronang Apr 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, nice catch.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 8, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@aaronang
Copy link
Copy Markdown
Contributor Author

aaronang commented Apr 9, 2018

I have made the requested changes; please review again

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 9, 2018

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

@ned-deily ned-deily merged commit 0f914b5 into python:master Apr 9, 2018
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Apr 9, 2018

Thanks @aaronang for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 9, 2018

GH-6437 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 9, 2018
@aaronang @miss-islington
bpo-31201: Clarify command to re-run failing test(s) with example (py…
563143e 
…thonGH-6417)

(cherry picked from commit 0f914b5)

Co-authored-by: Aaron Ang <aaronang@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 9, 2018
@aaronang @miss-islington
bpo-31201: Clarify command to re-run failing test(s) with example (py…
fa06845 
…thonGH-6417)

(cherry picked from commit 0f914b5)

Co-authored-by: Aaron Ang <aaronang@users.noreply.github.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 9, 2018

GH-6438 is a backport of this pull request to the 3.6 branch.

ned-deily pushed a commit that referenced this pull request Apr 9, 2018
@miss-islington @aaronang @ned-deily
[3.7] bpo-31201: Clarify command to re-run failing test(s) with examp…
71a3837 
…le (GH-6417) (GH-6437)

(cherry picked from commit 0f914b5)

Co-authored-by: Aaron Ang <aaronang@users.noreply.github.com>
ned-deily pushed a commit that referenced this pull request Apr 9, 2018
@miss-islington @aaronang @ned-deily
[3.6] bpo-31201: Clarify command to re-run failing test(s) with examp…
83bb399 
…le (GH-6417) (GH-6438)

(cherry picked from commit 0f914b5)

Co-authored-by: Aaron Ang <aaronang@users.noreply.github.com>
@aaronang aaronang deleted the bpo-31201 branch April 10, 2018 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aaronang @the-knights-who-say-ni @bedevere-bot @miss-islington @ned-deily