bpo-29673: Some gdb macros are broken in 3.6#6126
Conversation
ghost
changed the title
ghost
changed the title
There was a problem hiding this comment.
Thanks for including a NEWS entry. However, this is a bit too detailed. See a current changelog to get a sense of the level of detail we use. This kind of detail might be appropriate for a commit message.
smontanaro
left a comment
smontanaro
left a comment
There was a problem hiding this comment.
LGTM, modulo Ned's NEWS file comment. (I am really surprised this little hack has lived this long...)
ned-deily
left a comment
ned-deily
left a comment
There was a problem hiding this comment.
Thanks for the review, @smontanaro , and the changes, @Traceur759. Almost there!
Misc/ACKS
Outdated
There was a problem hiding this comment.
A nit: we try to keep the ACKs list in alphabetical order by family name. So please insert your name in the "P" section. Thanks!
There was a problem hiding this comment.
Thanks for condensing the NEWS entry. But I think it is still too detailed and does not really answer the question of what was fixed; why it was fixed is not so important here. Also, if you wish, you can add your name here. An example from the Developer's Guide:
Fix warning message when
os.chdir()fails inside
test.support.temp_cwd(). Patch by Chris Jerdonek.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @ned-deily: please review the changes made to this pull request. |
|
Thanks @Traceur759 for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-6399 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit 3a9ccee) Co-authored-by: Marcel Plch <gmarcel.plch@gmail.com>
(cherry picked from commit 3a9ccee) Co-authored-by: Marcel Plch <gmarcel.plch@gmail.com>
|
GH-6400 is a backport of this pull request to the 3.6 branch. |
5 participants
This PR fixes broken scripts for printing of Python call stack from GDB.
https://bugs.python.org/issue29673