gh-149259: Fix median_grouped() exception chaining and error messages#149260
Closed
htjworld wants to merge 1 commit intopython:mainfrom
Closed
gh-149259: Fix median_grouped() exception chaining and error messages#149260htjworld wants to merge 1 commit intopython:mainfrom
htjworld wants to merge 1 commit intopython:mainfrom
Conversation
…ssages Split the single try/except block into two, add `from exc` chaining so the original ValueError is visible in tracebacks, and improve the error messages to identify whether `interval` or the data value failed the float conversion.
Documentation build overview
30 files changed ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #149259.
median_grouped()placed both float conversions in a singletryblockwith no
from excchaining, so the originalValueErrorwas silentlydiscarded and the message gave no clue which argument failed.
tryblocks sointervaland data failures arereported separately.
from excso the originalValueErrorappears in tracebacks.interval must be a real number, got 'bad'vsdata sequence must contain real numbers, found 'b'.No behaviour change for callers (still
TypeErrorin the same cases).A new test
test_exception_chaining_and_messagesverifies the chainand message content.