gh-148074: Fix `typeobject.c` missing error return by Wulian233 · Pull Request #148075 · python/cpython

Wulian233 · 2026-04-04T08:37:47Z

At line 9314-9320, PyErr_Format sets a SystemError for invalid tp_dictoffset but falls through to return 0 (success). Type finishes initialization with invalid offset and pending exception. Requires C extension to trigger.

I think we can skip-news

Issue: typeobject.c: Missing return -1 after PyErr_Format in type_ready_post_checks #148074

miss-islington-app · 2026-04-04T15:35:22Z

Thanks @Wulian233 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

…8075) (cherry picked from commit c398490) Co-authored-by: Wulian233 <1055917385@qq.com>

bedevere-app · 2026-04-04T15:35:29Z

GH-148095 is a backport of this pull request to the 3.14 branch.

bedevere-bot · 2026-04-04T15:55:16Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit c398490.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/13847) and take a look at the build logs.
Check if the failure is related to this commit (c398490) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/13847

Failed tests:

test_zipimport

Failed subtests:

testBoth - test.test_zipimport.UncompressedZipImportTestCase.testBoth
testGetCompiledSource - test.test_zipimport.UncompressedZipImportTestCase.testGetCompiledSource
testBoth - test.test_zipimport.DeflateCompressedZipImportTestCase.testBoth
testGetCompiledSource - test.test_zipimport.DeflateCompressedZipImportTestCase.testGetCompiledSource

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (test.test_zipimport.UncompressedZipImportTestCase.testTraceback) ... ok


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 801, in testGetCompiledSource
    self.doTest(pyc_ext, files, TESTMOD, call=self.assertModuleSource)
    ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 159, in doTest
    self.doTestWithPreBuiltZip(expected_ext, *modules, **kw)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 173, in doTestWithPreBuiltZip
    self.assertEqual(file, os.path.join(zip_path,
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                         *modules) + expected_ext)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: '/roo[47 chars]ld/test_python_761360æ/junk95142.zip/pre/fix/ziptestmodule.py' != '/roo[47 chars]ld/test_python_761360æ/junk95142.zip/pre/fix/ziptestmodule.pyc'
- /root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_761360æ/junk95142.zip/pre/fix/ziptestmodule.py
+ /root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_761360æ/junk95142.zip/pre/fix/ziptestmodule.pyc
?                                                                                                                 +


Traceback (test.test_zipimport.DeflateCompressedZipImportTestCase.testTraceback) ... ok


Traceback (test.test_zipimport.ZStdCompressedZipImportTestCase.testTraceback) ... skipped 'requires zstd'


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 801, in testGetCompiledSource
    self.doTest(pyc_ext, files, TESTMOD, call=self.assertModuleSource)
    ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 159, in doTest
    self.doTestWithPreBuiltZip(expected_ext, *modules, **kw)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 173, in doTestWithPreBuiltZip
    self.assertEqual(file, os.path.join(zip_path,
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                         *modules) + expected_ext)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: '/roo[47 chars]ld/test_python_765254æ/junk95142.zip/pre/fix/ziptestmodule.py' != '/roo[47 chars]ld/test_python_765254æ/junk95142.zip/pre/fix/ziptestmodule.pyc'
- /root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_765254æ/junk95142.zip/pre/fix/ziptestmodule.py
+ /root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_765254æ/junk95142.zip/pre/fix/ziptestmodule.pyc
?                                                                                                                 +


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 239, in testBoth
    self.doTest(pyc_ext, files, TESTMOD)
    ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 159, in doTest
    self.doTestWithPreBuiltZip(expected_ext, *modules, **kw)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 173, in doTestWithPreBuiltZip
    self.assertEqual(file, os.path.join(zip_path,
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                         *modules) + expected_ext)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: '/roo[47 chars]ld/test_python_765254æ/junk95142.zip/pre/fix/ziptestmodule.py' != '/roo[47 chars]ld/test_python_765254æ/junk95142.zip/pre/fix/ziptestmodule.pyc'
- /root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_765254æ/junk95142.zip/pre/fix/ziptestmodule.py
+ /root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_765254æ/junk95142.zip/pre/fix/ziptestmodule.pyc
?                                                                                                                 +


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 239, in testBoth
    self.doTest(pyc_ext, files, TESTMOD)
    ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 159, in doTest
    self.doTestWithPreBuiltZip(expected_ext, *modules, **kw)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 173, in doTestWithPreBuiltZip
    self.assertEqual(file, os.path.join(zip_path,
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                         *modules) + expected_ext)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: '/roo[47 chars]ld/test_python_761360æ/junk95142.zip/pre/fix/ziptestmodule.py' != '/roo[47 chars]ld/test_python_761360æ/junk95142.zip/pre/fix/ziptestmodule.pyc'
- /root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_761360æ/junk95142.zip/pre/fix/ziptestmodule.py
+ /root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_761360æ/junk95142.zip/pre/fix/ziptestmodule.pyc
?                                                                                                                 +

…#148095) gh-148074: Fix `typeobject.c` missing error return (GH-148075) (cherry picked from commit c398490) Co-authored-by: Wulian233 <1055917385@qq.com>

pythongh-148074: Fix typeobject.c missing error return

3dc743f

Wulian233 requested a review from markshannon as a code owner April 4, 2026 08:37

bedevere-app bot added the awaiting review label Apr 4, 2026

bedevere-app bot mentioned this pull request Apr 4, 2026

typeobject.c: Missing return -1 after PyErr_Format in type_ready_post_checks #148074

Closed

kumaraditya303 approved these changes Apr 4, 2026

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Apr 4, 2026

kumaraditya303 added the skip news label Apr 4, 2026

kumaraditya303 merged commit c398490 into python:main Apr 4, 2026
59 checks passed

bedevere-app bot removed the awaiting merge label Apr 4, 2026

kumaraditya303 added the needs backport to 3.14 bugs and security fixes label Apr 4, 2026

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 4, 2026

pythongh-148074: Fix typeobject.c missing error return (pythonGH-14…

9c13833

…8075) (cherry picked from commit c398490) Co-authored-by: Wulian233 <1055917385@qq.com>

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Apr 4, 2026

Wulian233 deleted the type branch April 4, 2026 20:05

pablogsal mentioned this pull request Apr 4, 2026

gh-130273: Fix traceback color output with unicode characters #142529

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

gh-148074: Fix `typeobject.c` missing error return#148075

gh-148074: Fix `typeobject.c` missing error return#148075
kumaraditya303 merged 1 commit intopython:mainfrom
Wulian233:type

Wulian233 commented Apr 4, 2026 •

edited by bedevere-app bot

Loading

Uh oh!

Uh oh!

miss-islington-app bot commented Apr 4, 2026

Uh oh!

bedevere-app bot commented Apr 4, 2026

Uh oh!

bedevere-bot commented Apr 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Wulian233 commented Apr 4, 2026 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

miss-islington-app bot commented Apr 4, 2026

Uh oh!

bedevere-app bot commented Apr 4, 2026

Uh oh!

bedevere-bot commented Apr 4, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Wulian233 commented Apr 4, 2026 •

edited by bedevere-app bot

Loading