Skip to content

gh-145866: Convert DICT_UPDATE to leave its inputs on the stack to be cleaned up by _POP_TOP#146190

Merged
Fidget-Spinner merged 7 commits intopython:mainfrom
Sacul0457:Optimize_DICT_UPDATE
Mar 26, 2026
Merged

gh-145866: Convert DICT_UPDATE to leave its inputs on the stack to be cleaned up by _POP_TOP#146190
Fidget-Spinner merged 7 commits intopython:mainfrom
Sacul0457:Optimize_DICT_UPDATE

Conversation

@Sacul0457
Copy link
Contributor

@Sacul0457 Sacul0457 commented Mar 20, 2026

@Fidget-Spinner
Copy link
Member

Please merge in main again. Sorry!

@Fidget-Spinner
Copy link
Member

Sorry, more stuff got merge conflicted, please pull in main and regenerate again! I'll put this in the queue next to merge.

@Fidget-Spinner Fidget-Spinner merged commit 1516c26 into python:main Mar 26, 2026
74 checks passed
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 CentOS9 NoGIL 3.x (tier-1) has failed when building commit 1516c26.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1609/builds/5221) and take a look at the build logs.
  4. Check if the failure is related to this commit (1516c26) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1609/builds/5221

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.itamaro-centos-aws.nogil/build/Lib/test/support/__init__.py", line 947, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True>


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.itamaro-centos-aws.nogil/build/Lib/test/support/__init__.py", line 947, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed file <_io.FileIO name=10 mode='wb' closefd=True>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants