gh-140502: fix default REPL does not handle tab right#140697
Closed
yihong0618 wants to merge 5 commits intopython:mainfrom
yihong0618:close_issue_140502
Closed
gh-140502: fix default REPL does not handle tab right#140697yihong0618 wants to merge 5 commits intopython:mainfrom yihong0618:close_issue_140502
yihong0618 wants to merge 5 commits intopython:mainfrom
yihong0618:close_issue_140502
Conversation
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Contributor
|
On windows it works as expected without patch. After patch: So, it seems working. |
Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Contributor
|
@pablogsal @ambv Could you please take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and found there is no test for
disp_stralso add a test for it.
after this patch
cc @sergey-miryanov