GH-101291: Rearrange the size bits in PyLongObject#102464
Merged
markshannon merged 37 commits intopython:mainfrom Mar 22, 2023
Merged
GH-101291: Rearrange the size bits in PyLongObject#102464markshannon merged 37 commits intopython:mainfrom
markshannon merged 37 commits intopython:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rearranges the bits in what was
ob_size, to slightly speedup the most common operations and to prepare for storing the tagged 2-complement value directly in a future PR.The new layout is as follows:
The bulk of the change is removing all the uses of
Py_SIZEandPy_SETSIZE, and replacing them with a new set of inline functions.It disturbs me how much we use unchecked casts, but that's a separate issue...
This will, inevitably, break Cython generated code again.
Performance measurement shows no significant change: https://github.com/faster-cpython/benchmarking/tree/main/results/bm-20230302-3.12.0a5%2B-ce6bfb2