Replace gh-issue-NNNN: with gh-NNNN: in the output#451
Merged
ezio-melotti merged 1 commit intomasterfrom Jul 14, 2022
Merged
Conversation
erlend-aasland
approved these changes
Jul 14, 2022
erlend-aasland
left a comment
erlend-aasland
left a comment
There was a problem hiding this comment.
Makes sense. Does this also need a doc update?
Member
Author
|
Which docs do you mean? |
I should have phrased myself clearer :) If there are any docs that mention this, they would need an update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed in python/cpython#92448 that the output shows
gh-issues-NNNN:instead ofgh-NNNN:. I had initially proposed to usegh-issueinstead of justissuein the content of the entry because in that case is ambiguous and people might have added the bpo number. In the output there is no such problem, andgh-NNNNis enough.AFAIU if this PR is applied, it will update older news entries too, right?