This repository was archived by the owner on Jun 22, 2025. It is now read-only.
More Reliable Regex for eel.expose()#94
Merged
ChrisKnott merged 1 commit intopython-eel:masterfrom Jan 1, 2019
KyleKing:dev/improve-static-analysis
Merged
More Reliable Regex for eel.expose()#94ChrisKnott merged 1 commit intopython-eel:masterfrom KyleKing:dev/improve-static-analysis
eel.expose()#94ChrisKnott merged 1 commit intopython-eel:masterfrom
KyleKing:dev/improve-static-analysis
Conversation
Collaborator
|
@KyleKing Thanks, this is great, been meaning to do this for a while. |
Contributor
Author
|
That was insanely fast, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I extended the
eel.expose(*)regex parser ininit()to identify the optionalnameparameter. Now in JavaSscript you can typeeel.expose(funcName, 'func_name'), then calleel.func_name()in Python. The change is backward compatible and now enables using Eel with minified and uglified code like the output from Create-React-App (I'm preparing a separate PR for an example of CRA)There is now an optional argument to
init()to specifyallowed_extensions. This should close: #61I also made a few minor changes to the README. I added a Table of Contents, ran Prettier, fixed a couple of typos, and clarified building a binary with PyInstaller. Let me know if you want me to revert or modify anything.