You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
C PURPOSE
C
C To extract from the system pencil
C
C ( A-lambda*E B )
C S(lambda) = ( )
C ( C D )
C
C a regular pencil Af-lambda*Ef which has the finite Smith zeros of
C S(lambda) as generalized eigenvalues. The routine also computes
C the orders of the infinite Smith zeros and determines the singular
C and infinite Kronecker structure of system pencil, i.e., the right
C and left Kronecker indices, and the multiplicities of infinite
C eigenvalues.
As reported in #157, some math libraries out there compute Af, Ef with a different scaling as the SLICOT example. The result should still be valid.
Looks good to me; from Wikipedia the generalized eigenvalue problem is Af @ x == lambda * Ef @ x, so Af and Ef are not unique.
This change can't be causing the test failures. I see control/tests/flatsys_test.py::TestFlatSys::test_point_to_point_errors is common to all the failing runs, and that two cases fail control/tests/timeresp_test.py::TestTimeresp::test_forced_response_T_U[dt=True, no T] and control/tests/timeresp_test.py::TestTimeresp::test_forced_response_T_U[dt=0.2, no T]. I don't have any suggestions for this, except the not-so-helpful one of ignoring the failures and merging anyway.
The mentioned failures should be fixed by python-control/python-control#659. I just retriggered the CI jobs now. If it succeeds, all is well. If not, we can still ignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #157
From the AG08BD.f docstring:
As reported in #157, some math libraries out there compute
Af,Efwith a different scaling as the SLICOT example. The result should still be valid.