Refactor project configuration and update dependencies#118
Merged
Conversation
Owner
ptr727
commented
Apr 14, 2026
ptr727
commented
- Updated build-library-task.yml to specify OutputPath and PackageOutputPath for dotnet build.
- Changed concurrency group in run-periodic-codegen-pull-request.yml to target main/codegen.
- Modified launch.json to reflect new output paths for the LanguageTagsCreate project.
- Enhanced AGENTS.md with project configuration guidelines and centralized NuGet package versions.
- Updated LanguageData/rfc5646 and LanguageData/rfc5646.json with new language subtags and descriptions.
- Cleaned up GlobalUsings.cs files by removing unused namespaces.
- Adjusted LanguageTags.csproj and LanguageTagsCreate.csproj to centralize package versions and remove unnecessary properties.
- Improved HttpClientFactory.cs with resilience strategies using Polly for better error handling.
- Added Directory.Build.props and Directory.Packages.props for centralized project settings and package version management.
- Updated LanguageTagsTests project to remove unnecessary properties and centralize package references.
- Updated build-library-task.yml to specify OutputPath and PackageOutputPath for dotnet build. - Changed concurrency group in run-periodic-codegen-pull-request.yml to target main/codegen. - Modified launch.json to reflect new output paths for the LanguageTagsCreate project. - Enhanced AGENTS.md with project configuration guidelines and centralized NuGet package versions. - Updated LanguageData/rfc5646 and LanguageData/rfc5646.json with new language subtags and descriptions. - Cleaned up GlobalUsings.cs files by removing unused namespaces. - Adjusted LanguageTags.csproj and LanguageTagsCreate.csproj to centralize package versions and remove unnecessary properties. - Improved HttpClientFactory.cs with resilience strategies using Polly for better error handling. - Added Directory.Build.props and Directory.Packages.props for centralized project settings and package version management. - Updated LanguageTagsTests project to remove unnecessary properties and centralize package references.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors solution-wide build/project configuration (central MSBuild properties + central NuGet version management), updates CI/workflow settings, refreshes RFC 5646 language registry data, and improves the LanguageTagsCreate HTTP client resilience configuration.
Changes:
- Introduce centralized MSBuild defaults (
Directory.Build.props) and centralized package versions (Directory.Packages.props), updating project files to rely on them. - Update workflows and VS Code launch config to align with the new build/output conventions.
- Refresh RFC 5646 registry data (source + JSON + generated C#) and enhance
LanguageTagsCreateHTTP resilience behavior.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| LanguageTagsTests/LanguageTagsTests.csproj | Remove per-project properties/versions to rely on central props and central package versions. |
| LanguageTagsTests/GlobalUsings.cs | Remove redundant global usings now covered by implicit usings. |
| LanguageTagsCreate/LanguageTagsCreate.csproj | Remove duplicated properties and move package versions to central management. |
| LanguageTagsCreate/HttpClientFactory.cs | Add retry/circuit-breaker logging and refactor resilience configuration. |
| LanguageTagsCreate/GlobalUsings.cs | Remove redundant global usings. |
| LanguageTags/Rfc5646DataGen.cs | Update generated RFC 5646 registry data (new file date, records, descriptions). |
| LanguageTags/LogOptions.cs | Remove unused System.Threading import. |
| LanguageTags/LanguageTags.csproj | Align with centralized props/versions; explicitly set packable behavior for library packaging. |
| LanguageTags/GlobalUsings.cs | Remove redundant global usings. |
| LanguageData/rfc5646.json | Update RFC 5646 JSON registry snapshot (new/changed subtags and metadata). |
| LanguageData/rfc5646 | Update RFC 5646 source registry snapshot (new/changed subtags and metadata). |
| Directory.Packages.props | Add central NuGet package version definitions. |
| Directory.Build.props | Add shared MSBuild defaults for the whole solution. |
| AGENTS.md | Document centralized project configuration guidance. |
| .vscode/launch.json | Update debug launch paths to match new intended output layout. |
| .github/workflows/run-periodic-codegen-pull-request.yml | Adjust concurrency group behavior for the periodic codegen workflow. |
| .github/workflows/build-library-task.yml | Update build output/package output paths for CI builds. |
| .github/copilot-instructions.md | Document centralized project configuration guidance for contributors/agents. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.