Skip to content

feat(admin): settings ui#4866

Open
alexevladgabriel wants to merge 16 commits into
pterodactyl:old-developfrom
alexevladgabriel:feat/settings-ui
Open

feat(admin): settings ui#4866
alexevladgabriel wants to merge 16 commits into
pterodactyl:old-developfrom
alexevladgabriel:feat/settings-ui

Conversation

@alexevladgabriel

@alexevladgabriel alexevladgabriel commented Sep 21, 2023

Copy link
Copy Markdown

First task done:

  • Fixing route handler for admin settings

Backend

Settings

  • Created base controller, added default json response with data
  • Make transformer to normalize the API response

Frontend

General Settings

  • Submit handler
  • Add default fields from v1.0
  • Populate fields with data

Security Settings

  • Submit handler
  • Add default fields from v1.0
  • Populate fields with data

Advanced Settings

  • Submit handler
  • Add default fields from v1.0
  • Populate fields with data

@alexevladgabriel

Copy link
Copy Markdown
Author

image
image

@alexevladgabriel alexevladgabriel changed the title Feature : Settings UI Feature: Settings UI Sep 21, 2023
@alexevladgabriel

Copy link
Copy Markdown
Author

I've didn't see your PR #4733 @omametech.
I'm glad to see people like you willing to help.

@alexevladgabriel

Copy link
Copy Markdown
Author

Require to make transformer to normalize API format. Look into it tomorrow.

image

@QuintenQVD0

QuintenQVD0 commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

@alexevladgabriel Google analytics are not present anymore in the latest panel release

See:

@alexevladgabriel

Copy link
Copy Markdown
Author

@alexevladgabriel Google analytics are not present anymore in the latest panel release

See:

* [ref: remove google analytics #3912](https://github.com/pterodactyl/panel/pull/3912)

* https://github.com/pterodactyl/panel/blob/1.0-develop/database/migrations/2022_01_25_030847_drop_google_analytics.php

Google Analytics was not added by me, it was already existent setting in the v2. I would love to integrate other solutions for analytics, more focussed on privacy.

  • Plausible
  • Fathom

I will indeed remove it from UI.

@alexevladgabriel

Copy link
Copy Markdown
Author

image

@alexevladgabriel

alexevladgabriel commented Sep 22, 2023

Copy link
Copy Markdown
Author

Require to find a better method for data passing between main component & childrens, maybe useContext or store.

@alexevladgabriel alexevladgabriel changed the title Feature: Settings UI feat(admin): settings ui Sep 22, 2023
@alexevladgabriel

Copy link
Copy Markdown
Author

Remained to handle the updates with backend.

@camden-git

camden-git commented Oct 1, 2023

Copy link
Copy Markdown

I feel like the settings UI with all of the boxes gets really cluttered and convoluted, I could PR something off this to try and clean it up. Glad to see some work in public pterodactyl, it's been a long time.

@camden-git

Copy link
Copy Markdown

Playing with the design right now and I feel like having 5 (4 real) pages doesn't make sense. The general page has 2 settings and one of which does nothing. Maybe move everything but mail into one tab? We could do sections to separate the forms, something like this.
image

@camden-git

Copy link
Copy Markdown

@alexevladgabriel What do you think about the changes I said above?

@alexevladgabriel

Copy link
Copy Markdown
Author

@alexevladgabriel What do you think about the changes I said above?

I've looked into more designs from multiple sources & real apps usage. My only issue with the current design would be that there are to many box in boxes. I like the separation of the settings based on tabs (pages). At this moment there isn't enough content, to fill the pages and can be "really cluttered and convoluted" how you said. I will look more on design ideas, sketches in remaining time and attach here some screenshots.

@matthewpi

Copy link
Copy Markdown
Member

@alexevladgabriel What do you think about the changes I said above?

I've looked into more designs from multiple sources & real apps usage. My only issue with the current design would be that there are to many box in boxes. I like the separation of the settings based on tabs (pages). At this moment there isn't enough content, to fill the pages and can be "really cluttered and convoluted" how you said. I will look more on design ideas, sketches in remaining time and attach here some screenshots.

In terms of this PR, worry about functionality. Before any of the v2 changes get properly released there will be multiple polish passes on the UI.

@alexevladgabriel

Copy link
Copy Markdown
Author

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewpi is a good idea to use transformers for settings page, for me at least it seems more boilerplate code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

4 participants