fix(Dropdown): prevent item selection on Escape key press#7863
Merged
melloware merged 1 commit intoprimefaces:masterfrom Apr 6, 2025
Merged
fix(Dropdown): prevent item selection on Escape key press#7863melloware merged 1 commit intoprimefaces:masterfrom
melloware merged 1 commit intoprimefaces:masterfrom
Conversation
|
Deployment failed with the following error: |
melloware
approved these changes
Apr 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defect Fixes
How To Resolve
Issue Summary
Expected Behavior
Root Cause
hide(), but instead callsonEnterKey()— the logic used for selecting items.Fix Applied
onEscapeKey(), instead of callingonEnterKey().Test Results
2025-04-06.4.47.39.mov
problem1.mov
result.mov
2025-04-06.5.23.03.mov