Fix eslint warnings and bump actions/checkout to v5#15
Merged
Conversation
- Drop the unused `openPalette` import and the dead `focusLibraryLink` function in frontend/js/gamepad-nav.js (eslint no-unused-vars). - Bump actions/checkout from v4 to v5 in the backend, frontend, and release workflows. v4 runs on the deprecated Node.js 20 runtime; v5 runs on Node.js 24, removing the runner deprecation warning. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two issues surfaced by the latest CI runs, fixed together.
eslint errors in
frontend/js/gamepad-nav.jsBoth are genuinely dead code:
openPaletteis imported but never called ingamepad-nav.js(it's used inshell.jsandcommand-palette.js, which import it directly).focusLibraryLinkis defined but referenced nowhere in the codebase.Deleted both rather than renaming with
_prefix — dead code shouldn't be carried forward.actions/checkout@v4Node.js 20 deprecation warningBumped
actions/checkout@v4→@v5in all three workflows (backend, frontend, release). v5 runs on Node.js 24, clearing the warning ahead of the June 2026 cutoff.Test plan
npm run lintpasses locally with zero warnings🤖 Generated with Claude Code