Message filtering support#14
Conversation
There was a problem hiding this comment.
Any particular reason for using a constant versus just referencing FilterInterface::class where needed?
There was a problem hiding this comment.
Force of 5.4 habbit, I'll update both of them
|
Took care of the PHP 5.4 stuff and added a new filter that lets you filter on |
Conflicts: README.md composer.json composer.lock
|
Rebased master into this PR so it can be merged without issues. |
There was a problem hiding this comment.
Would returning null here would make more sense semantically (i.e. to imply the lack of a value)?
There was a problem hiding this comment.
The reasoning for using false is the failure of finding a value. If your preference is using null that can be arranged 😄
There was a problem hiding this comment.
Yeah, I think null makes more sense here.
|
👍 |
|
@svpernova09 @PSchwisow Any of you has any comments on this? Otherwise I'de like to merge and tag 3.1.0 tomorrow. |
3 participants
As discussed in #11