fix(ui): split only on first colon in toast error messages#15894
Merged
GermanJablo merged 2 commits intomainfrom Mar 10, 2026
Merged
fix(ui): split only on first colon in toast error messages#15894GermanJablo merged 2 commits intomainfrom
GermanJablo merged 2 commits intomainfrom
Conversation
Cover the colon-splitting behavior in toast error messages. Includes a failing test for messages with multiple colons.
Messages with multiple colons (e.g. "With: multiple: colons") were
truncated because split(':') discards everything past the second
colon during array destructuring. Use indexOf/slice to split only
on the first colon.
JessRynkar
approved these changes
Mar 10, 2026
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
Contributor
|
🚀 This is included in version v3.79.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Toast notifications truncate error messages that contain multiple colons. For example,
throw new APIError('With: multiple: colons', 400, undefined, true)only displays "With: multiple" in the toast — everything after the second colon is dropped.Changes
createErrorsFromMessageinpackages/ui/src/elements/Toasts/fieldErrors.tsxusedmessage.split(':')and destructured only the first two elements, discarding anything after the second colon. Replaced withindexOf/sliceto split only on the first colon, so the full message is preserved.Testing
Without the fix, the test "should preserve the full message when it contains multiple colons" fails with: