Skip to content

feat: check PyPI registry when deps.dev fails to find a source repository#982

Merged
benmss merged 17 commits intomainfrom
980-missing-pypi-packages
Apr 15, 2025
Merged

feat: check PyPI registry when deps.dev fails to find a source repository#982
benmss merged 17 commits intomainfrom
980-missing-pypi-packages

Conversation

@benmss
Copy link
Copy Markdown
Member

@benmss benmss commented Feb 10, 2025 •
edited
Loading

  • Use JSON from PyPI to find more repositories
  • Add tests
  • Fix circular dependency
  • Ensure reuse of downloaded assets

Closes #980

@benmss benmss self-assigned this Feb 10, 2025
@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 10, 2025
@benmss benmss force-pushed the 980-missing-pypi-packages branch from aec7196 to 165f611 Compare February 12, 2025 23:07
art1f1c3R
art1f1c3R reviewed Feb 13, 2025
View reviewed changes
Comment thread src/macaron/repo_finder/repo_finder_pypi.py Outdated
@benmss benmss marked this pull request as ready for review February 17, 2025 01:12
@benmss benmss force-pushed the 980-missing-pypi-packages branch 2 times, most recently from 4b16ac3 to 1cff217 Compare March 12, 2025 03:18
@benmss benmss mentioned this pull request Mar 19, 2025
Merged
2 tasks
behnazh-w
behnazh-w reviewed Mar 19, 2025
View reviewed changes
Comment thread tests/integration/cases/repo_finder_pypi/test.yaml
@benmss benmss force-pushed the 980-missing-pypi-packages branch from 1cff217 to 7956693 Compare March 19, 2025 01:06
behnazh-w
behnazh-w reviewed Mar 20, 2025
View reviewed changes
Comment thread src/macaron/repo_finder/repo_finder_pypi.py Outdated
Comment thread src/macaron/repo_finder/repo_finder.py Outdated
behnazh-w
behnazh-w reviewed Mar 20, 2025
View reviewed changes
Comment thread src/macaron/repo_finder/repo_finder_pypi.py Outdated
Comment thread src/macaron/repo_finder/repo_finder_pypi.py Outdated
behnazh-w
behnazh-w reviewed Mar 20, 2025
View reviewed changes
Comment thread tests/integration/cases/repo_finder_pypi_find_source/test.yaml
@benmss benmss changed the base branch from staging to main April 8, 2025 06:39
@benmss benmss force-pushed the 980-missing-pypi-packages branch 2 times, most recently from cca802a to 5a9029f Compare April 10, 2025 00:09
behnazh-w
behnazh-w reviewed Apr 10, 2025
View reviewed changes
Comment thread src/macaron/repo_finder/repo_finder_pypi.py
benmss added 10 commits April 15, 2025 10:05
@benmss
feat: check PyPI registry when deps.dev fails to find a source reposi…
2558b9f 
…tory

Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@benmss
chore: avoid circular dependency
c1750f8 
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@benmss
chore: add alternative find repo for latest purl version also
ddcd963 
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@benmss
chore: add integration test
60d7a12 
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@benmss
chore: update tests
9c5535d 
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@benmss
chore: pass build tool names to super class
058b94b 
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@benmss
chore: reuse PyPI JSON asset
73fa8e9 
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@benmss
chore: update tests
9a71ab5 
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@benmss
chore: add purl type to build tool in registry info
886a194 
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@benmss
chore: add repository info for source code heuristic; minor fixes
0842d8d 
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
benmss added 7 commits April 15, 2025 10:05
@benmss
chore: fix test
3ed6e53 
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@benmss
chore: minor fix
dc87f81 
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@benmss
chore: add integration test for find-source command
993996b 
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@benmss
chore: address PR feedback
6244da9 
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@benmss
chore: ensure package registry is found properly; ensure asset is not…
c404735 
… downloaded twice

Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@benmss
chore: revert find_valid_repository_url change
dd1a61c 
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@benmss
chore: minor fix
2209b7a 
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
@benmss benmss force-pushed the 980-missing-pypi-packages branch from 5a9029f to 2209b7a Compare April 15, 2025 00:08
@behnazh-w behnazh-w self-requested a review April 15, 2025 00:41
@benmss benmss merged commit 6e41a3d into main Apr 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@art1f1c3R art1f1c3R art1f1c3R left review comments

@behnazh-w behnazh-w behnazh-w approved these changes

@tromai tromai Awaiting requested review from tromai

Assignees

@benmss benmss

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

deps.dev does not find some PyPI package github links

3 participants

@benmss @behnazh-w @art1f1c3R