feat: find repo from latest artifact when provided artifact has none#931
Merged
feat: find repo from latest artifact when provided artifact has none#931
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
benmss
force-pushed
the
benmss/latest-repo-finder
branch
from
70daa62 to
a2b6ba9
Compare
behnazh-w
reviewed
Nov 29, 2024
tromai
reviewed
Dec 9, 2024
benmss
force-pushed
the
benmss/latest-repo-finder
branch
from
92f4d51 to
9ea935b
Compare
Member
|
Can you please add an integration test for one of the artifacts that required this feature to find the correct repository? |
Member
Author
|
One is included here. |
Member
I meant to add an integration test with two steps for the |
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
benmss
force-pushed
the
benmss/latest-repo-finder
branch
from
9ea935b to
608cfe1
Compare
behnazh-w
reviewed
Dec 19, 2024
behnazh-w
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the Repo Finder by making it check for repositories using the latest version of an artifact if the provided version does not contain that information. This latest version finding behaviour is also added for the case where a Java PURL was provided without a version, and is added for the
find-sourcecommand.