Skip to content

Delivery rules correction for proper rollout key#351

Merged
The-inside-man merged 14 commits into
masterfrom
jbrown/fix-delivery-rules
Aug 9, 2021
Merged

Delivery rules correction for proper rollout key#351
The-inside-man merged 14 commits into
masterfrom
jbrown/fix-delivery-rules

Conversation

@The-inside-man

Copy link
Copy Markdown
Contributor

Summary

  • Update the rollout key to use experiments instead of experiments_map
  • Update tests to have sample delivery rules

Test plan

  • FSC

Issues

  • "OASIS-7812"

Comment thread tests/test_optimizely_config.py Outdated
@The-inside-man The-inside-man removed the request for review from a team July 23, 2021 19:10
@coveralls

coveralls commented Jul 23, 2021

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.2%) to 96.017% when pulling f8947f8 on jbrown/fix-delivery-rules into 637129a on master.

@The-inside-man

The-inside-man commented Jul 23, 2021

Copy link
Copy Markdown
Contributor Author

@msohailhussain @jaeopt Python seems to pass FSC here without any errors which is interesting...

V2 Config custom build - https://app.travis-ci.com/github/optimizely/fullstack-sdk-compatibility-suite/builds/233550803

@jaeopt jaeopt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment to clarify test cases. Other than that, LGTM

Comment thread tests/test_optimizely_config.py
@keppel2

keppel2 commented Jul 30, 2021

Copy link
Copy Markdown

To trigger continuous integration, I sometimes try to add or change a comment in .gitignore. I like to change the first line from '#' to '##' and also from '##' to '#'.

@The-inside-man

The-inside-man commented Jul 30, 2021

Copy link
Copy Markdown
Contributor Author

To trigger continuous integration, I sometimes try to add or change a comment in .gitignore. I like to change the first line from '#' to '##' and also from '##' to '#'.

If you log into travis, you can actually just go to the build and trigger it there rather than pushing up new commits. I usually just do that, unless I have some functional item I am checking like None verse False.

Comment thread optimizely/optimizely_config.py Outdated
@keppel2

keppel2 commented Aug 3, 2021

Copy link
Copy Markdown

To trigger continuous integration, I sometimes try to add or change a comment in .gitignore. I like to change the first line from '#' to '##' and also from '##' to '#'.

If you log into travis, you can actually just go to the build and trigger it there rather than pushing up new commits. I usually just do that, unless I have some functional item I am checking like None verse False.

I'm not sure if that updates the statuses on GitHub. I think this is useful for failing builds on our public repos--we have had some intermittent issues in python.

@The-inside-man

Copy link
Copy Markdown
Contributor Author

To trigger continuous integration, I sometimes try to add or change a comment in .gitignore. I like to change the first line from '#' to '##' and also from '##' to '#'.

If you log into travis, you can actually just go to the build and trigger it there rather than pushing up new commits. I usually just do that, unless I have some functional item I am checking like None verse False.

I'm not sure if that updates the statuses on GitHub. I think this is useful for failing builds on our public repos--we have had some intermittent issues in python.

Good call, I think you may be right on that. Rerunning from CI directly does not update the public build status.

@@ -133,7 +133,7 @@ def __init__(self, project_config):
optly_audience = OptimizelyAudience(

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, you can take a ref of typed_audiences using [].

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually going to make it simpler and just use project_config.typed_audiences reference in the loop rather than assign something new. Was doing things a bit differently previously and never cleaned up. Thanks for spotting.

…was unnecessary. Remove str cast as also not needed.
@The-inside-man

Copy link
Copy Markdown
Contributor Author

@The-inside-man

Copy link
Copy Markdown
Contributor Author

All tests passing!

@The-inside-man The-inside-man requested a review from Mat001 August 7, 2021 00:16

@Mat001 Mat001 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@The-inside-man The-inside-man merged commit 0cb19ce into master Aug 9, 2021
@The-inside-man The-inside-man deleted the jbrown/fix-delivery-rules branch August 9, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants