feat: ODP REST API for Sending ODP Events#315
Conversation
|
@msohailhussain Let me know if you want to pair up over this review. |
msohailhussain
left a comment
msohailhussain
left a comment
There was a problem hiding this comment.
not reviewed unit test. partial review to unblock if need to work on the feedback.
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks good. A few changes suggested.
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks good. A clarification regarding TLS.
Thanks @jaeopt . Holding for @msohailhussain 's approval 😉 |
msohailhussain
left a comment
msohailhussain
left a comment
There was a problem hiding this comment.
please address few more questions.
|
@mikechu-optimizely Overall your PR looks good, please address 4 more questions and then lgtm. |
|
last but not least please fix Lint issues. |
It seems like the lint error here in the GitHub Action is about a missing auth token. Would you like me to pause the Pull Request and resolve this step, so we can make the "Csharp CI with .NET / Lint Code Base (pull_request)" required? ...or are there lint issues that I missed in the code? Can you direct me to an example file? |
|
this is fine for me, we should resolve token issue in future. |
3 participants
Summary
Adding module to provide an internal service for sending events to ODP's REST API.
Test plan
Issues