[#74577] Build segmented control quickfilter #23014
Merged
Conversation
mrmir
force-pushed
the
feature/74577-build-primer-quickfilter
branch
from
369a18e to
6501c7f
Compare
klaustopher
reviewed
May 4, 2026
HDinger
requested changes
May 4, 2026
Contributor
HDinger
left a comment
HDinger
left a comment
There was a problem hiding this comment.
Looks good overall. I guess the component can be a bit polished and I would like to disucss the show_all flag before merging
mrmir
force-pushed
the
feature/74577-build-primer-quickfilter
branch
from
cf914a6 to
dd092f3
Compare
"My meetings" and "Invitations" were already showing the same results before, but passed their filter params differently. With changes to the way the filter params are passed in this PR, both now get highlighted for the same conditions, and so removing "Invitations" makes sense. Some changes are needed to the condition to ensure "My meetings" stays distinct from "All meetings", however.
mrmir
force-pushed
the
feature/74577-build-primer-quickfilter
branch
from
3bb1af2 to
9155f80
Compare
mrmir
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
HDinger
approved these changes
May 6, 2026
Contributor
HDinger
left a comment
HDinger
left a comment
There was a problem hiding this comment.
Looks very good 👍 I only have a very small comment
Co-authored-by: Henriette Darge <h.darge@openproject.com>
mrmir
force-pushed
the
feature/74577-build-primer-quickfilter
branch
from
119c0fc to
4e8c72f
Compare
Contributor
Author
|
Failing specs are flaky, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/74724
What approach did you choose and why?
QuickFilter::SegmentedComponentandQuickFilter::BooleanComponentMerge checklist