This repository was archived by the owner on Jun 27, 2020. It is now read-only.
Fix flake8 Travis issues#67
Merged
rohithasrk merged 1 commit intoopenwisp:masterfrom Dec 2, 2017
Merged
Conversation
|
Changes Unknown when pulling e2ad240 on AZtheAsian:master into ** on netjson:master**. |
1 similar comment
|
Changes Unknown when pulling e2ad240 on AZtheAsian:master into ** on netjson:master**. |
rohithasrk
approved these changes
Dec 1, 2017
Contributor
rohithasrk
left a comment
rohithasrk
left a comment
There was a problem hiding this comment.
Nice work @AZtheAsian. Change the commit message to something like [QA] Fixed flake8 errors in Travis build and you're ready to go. Otherwise LGTM 😄
Member
|
@AZtheAsian great work 👍 , please read about our commit message style |
|
Changes Unknown when pulling ed682a0 on AZtheAsian:master into ** on netjson:master**. |
rohithasrk
approved these changes
Dec 2, 2017
Contributor
|
Merged @AZtheAsian. Thanks ;) |
Member
|
👍 nice work @AZtheAsian |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.