Resource user mention notifications#2862
Draft
fschade wants to merge 4 commits into
Draft
Conversation
Not up to standards ⛔
|
0a8610a to
c971c11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
opencloud-eu/web#2601 by @JammingBen introduces the ability to mention users in collabora,
even if the ability for user completion on its own is already great, letting users know that they got mentioned is key requirement to make it feel complete.
The two channels for such notifications are: mail and sse.
SSE pops up in the web ui during usage, mail will pop up in the users inbox if the web-app is not opened.
Open questions
skip or fail notification
in some cases, mentioning users in private documents could be crucial, what should we do if the user has no access to the document?
a:error and do not notify any user at all?b:ignore the user, dont fail and notify all the other users with access?Related Issue
Motivation and Context
as described in the description, letting users know is a key requirement, its important to note, the notification is only send if the user can access the resource he got mentioned in.
Screenshots (if appropriate):
Types of changes
Checklist: