Skip to content

Invalidate Presence after one hour without motion updates. Upgrade Toolchain.#141

Merged
DivineThreepwood merged 13 commits into
devfrom
feature/140-improve-presence-detector
Apr 3, 2024
Merged

Invalidate Presence after one hour without motion updates. Upgrade Toolchain.#141
DivineThreepwood merged 13 commits into
devfrom
feature/140-improve-presence-detector

Conversation

@DivineThreepwood
Copy link
Copy Markdown
Member

@DivineThreepwood DivineThreepwood commented Mar 26, 2024

📜 Description

Changes proposed in this pull request:

  • Port Presence Detector to kotlin
  • Improve Kotlin code of the InfluxDB App.
  • Make sure the presence detector times out after one hour without any motion updates.
  • upgradle kotlin to 1.9.20
  • upgrade gradle to latest version

🔨 How to Test

  • Let a motion sensor generate an motion event.
  • Disconnect its battery and validate if the motion event times out after one hour.
  • Make sure the influx db app is properly working.

@DivineThreepwood
port Presence Detector to kotlin
c44dc72
@DivineThreepwood
Invalidate presence state in case no movement was detected since one …
6e69be7 
…hour. Some kotline improvements in the PresenceDetector and InfluxDbconnectorApp. Apply some changes to make the code compatible for java 21 including updating the kotlin version.
@DivineThreepwood
upgrade jul
7a23ed3
@DivineThreepwood
upgradle gradle
f62a7e4
@DivineThreepwood DivineThreepwood linked an issue Mar 26, 2024 that may be closed by this pull request
Improve Presence Detector #140
Closed
@DivineThreepwood DivineThreepwood added wip preview Auto build a docker image and deploy it as a preview version. labels Mar 26, 2024
@DivineThreepwood DivineThreepwood added ready to review and removed preview Auto build a docker image and deploy it as a preview version. wip labels Apr 2, 2024
lhuxohl
lhuxohl requested changes Apr 2, 2024
View reviewed changes
Comment thread ...fluxdbconnector/src/main/java/org/openbase/bco/app/influxdbconnector/InfluxDbconnectorApp.kt Outdated
Comment thread module/dal/remote/src/main/java/org/openbase/bco/dal/remote/detector/PresenceDetector.kt Outdated
Comment thread module/dal/remote/src/main/java/org/openbase/bco/dal/remote/detector/PresenceDetector.kt Outdated
@DivineThreepwood DivineThreepwood requested a review from lhuxohl April 2, 2024 19:26
lhuxohl
lhuxohl previously approved these changes Apr 2, 2024
View reviewed changes
@DivineThreepwood DivineThreepwood added the preview Auto build a docker image and deploy it as a preview version. label Apr 2, 2024
@DivineThreepwood DivineThreepwood marked this pull request as draft April 2, 2024 21:35
@DivineThreepwood DivineThreepwood marked this pull request as ready for review April 2, 2024 21:35
@DivineThreepwood DivineThreepwood merged commit 5e7ea56 into dev Apr 3, 2024
@DivineThreepwood DivineThreepwood deleted the feature/140-improve-presence-detector branch April 3, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhuxohl lhuxohl lhuxohl approved these changes

Assignees

No one assigned

Labels

code approved preview Auto build a docker image and deploy it as a preview version. tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve Presence Detector

2 participants

@DivineThreepwood @lhuxohl