Skip to content

CUST-5203: add "maybe" to Event Status, use "maybe" instead of deprecated "tentative", and gracefully handle unknown status#307

Merged
googsvg merged 2 commits intomainfrom
codex-CUST-5203-eventstatus-maybe-fallback
Mar 25, 2026
Merged

CUST-5203: add "maybe" to Event Status, use "maybe" instead of deprecated "tentative", and gracefully handle unknown status#307
googsvg merged 2 commits intomainfrom
codex-CUST-5203-eventstatus-maybe-fallback

Conversation

@googsvg
Copy link
Copy Markdown
Contributor

@googsvg googsvg commented Mar 24, 2026

Add "maybe" as an Event Status, and also add a graceful handler of unknown returned events instead of crashing with unknown JsonDataException (as described in the ticket).

Also, "maybe" is the new standard for Event Status instead of "tentative" (which will be deprecated one time in the future).

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.38%. Comparing base (76e3a87) to head (a1c4a29).

Files with missing lines Patch % Lines
...in/kotlin/com/nylas/util/EventStatusJsonAdapter.kt 38.46% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #307      +/-   ##
============================================
- Coverage     82.93%   82.38%   -0.56%     
- Complexity      348      354       +6     
============================================
  Files            36       37       +1     
  Lines          1002     1016      +14     
  Branches         94       95       +1     
============================================
+ Hits            831      837       +6     
- Misses          115      120       +5     
- Partials         56       59       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@googsvg googsvg changed the title CUST-5203: add "maybe" to Event Status, and gracefully handle unknown status CUST-5203: add "maybe" to Event Status, use "maybe" instead of deprecated "tentative", and gracefully handle unknown status Mar 24, 2026
@googsvg googsvg requested a review from AaronDDM March 24, 2026 16:04
@googsvg googsvg merged commit fd861fb into main Mar 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants