fix: ignore node prereleases in npm engines check#6574
Merged
Conversation
Member
Author
|
Gonna have to get clever in the test fixture |
Collaborator
|
no statistically significant performance changes detected timing results
|
lukekarrys
suggested changes
Jun 19, 2023
Member
Author
|
https://nodejs.org/download/release/ Do we even need the flag at all? |
Contributor
At the risk of prematurely optimizing, if Node ever did ship a prerelease we would want that flag (and the template-oss PR). So I think for the sake of having the code match our intent (even if it's not currently possible), we should land both PRs. |
They don't currently have any so that code would never have mattered cf https://nodejs.org/download/release/
0b8902e to
c420756
Compare
lukekarrys
approved these changes
Jun 20, 2023
Merged
lukekarrys
pushed a commit
that referenced
this pull request
Jun 20, 2023
They don't currently have any so that code would never have mattered cf https://nodejs.org/download/release/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They don't currently have any so that code would never have mattered
cf https://nodejs.org/download/release/