deps: move from @npmcli/ci-detect to ci-info#5858
Merged
Conversation
See watson/ci-info#95 for more context on achieving parity between these two modules. This changes npm to use `ci-info` instead of `@npmcli/ci-detect`. Everything that npm currently flags as a CI environment should still be doing so, so there is no breaking change there. There is going to be a subtle difference in the `ci-name` config, which nothing in npm currently looks at anyways, as well as the ci name that shows up in the default `user-agent` string. Some providers will be slightly different (i.e. circle-ci vs circleci and cirrus vs cirrus-ci)
wraithgar
force-pushed
the
gar/ci-info
branch
from
46cda63 to
c661789
Compare
Collaborator
|
no statistically significant performance changes detected timing results
|
nlf
approved these changes
Nov 16, 2022
Contributor
nlf
left a comment
nlf
left a comment
There was a problem hiding this comment.
one very minor nit you can take or leave, but this looks good otherwise
Merged
sibiraj-s
reviewed
Nov 17, 2022
| The name of a continuous integration system. If not set explicitly, npm | ||
| will detect the current CI environment using the | ||
| [\`@npmcli/ci-detect\`](http://npm.im/@npmcli/ci-detect) module. | ||
| [\`ci-info\`](http://npm.im/@npmcli/ci-info) module. |
There was a problem hiding this comment.
Invalid URL for ci-info. http://npm.im/ci-info.
Member
Author
There was a problem hiding this comment.
fiddlesticks. search and replace failed me, sorry about that.
this file is the source of truth, changing it and running snapshots will fix the rest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See watson/ci-info#95 for more context on
achieving parity between these two modules.
This changes npm to use
ci-infoinstead of@npmcli/ci-detect.Everything that npm currently flags as a CI environment should still be
doing so, so there is no breaking change there.
There is going to be a subtle difference in the
ci-nameconfig, whichnothing in npm currently looks at anyways, as well as the ci name that
shows up in the default
user-agentstring. Some providers will beslightly different (i.e. circle-ci vs circleci and cirrus vs cirrus-ci)