helpers/slashes.js: remove the process check.#2495
Merged
Trott merged 1 commit intonodejs:masterfrom Sep 4, 2019
XhmikosR:master-xmr-slash
Merged
helpers/slashes.js: remove the process check.#2495Trott merged 1 commit intonodejs:masterfrom XhmikosR:master-xmr-slash
Trott merged 1 commit intonodejs:masterfrom
XhmikosR:master-xmr-slash
Conversation
XhmikosR
commented
Sep 4, 2019
|
|
||
| module.exports = function (str) { | ||
| return process.platform === 'win32' && str.replace(/\\/g, '/') | ||
| return str.replace(/\\/g, '/') |
Contributor
Author
There was a problem hiding this comment.
Alternatively, if you still want the check I can change it to a ternary.
That being said, this way is consistent with one more case we have to replace the slashes where we don't check for process.
Trott
approved these changes
Sep 4, 2019
Member
|
I'm going to go ahead and merge this right away. If it causes problems, it should be easy enough to back out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for the regression, my initial patch didn't include the process check, but due to a review comment I added it, which I shouldn't have.
/CC @Trott @MaledongGit please try on nix and merge ASAP.
Fixes #2494