doc: change some URLs from 'http' to https'#2490
Merged
Trott merged 1 commit intonodejs:masterfrom Sep 4, 2019
SEWeiTung:master
Merged
doc: change some URLs from 'http' to https'#2490Trott merged 1 commit intonodejs:masterfrom SEWeiTung:master
Trott merged 1 commit intonodejs:masterfrom
SEWeiTung:master
Conversation
There're some URLs that starts with 'https', change them together. 1. http://c-ares.haxx.se/docs.html => https://c-ares.haxx.se/docs.html. 2. http://ibm.biz/ibmi-rpms => https://ibm.biz/ibmi-rpms.
SEWeiTung
requested review from
3imed-jaberi,
Aissaoui-Ahmed,
ZYSzys and
celyes
and removed request for
Aissaoui-Ahmed and
celyes
XhmikosR
approved these changes
Sep 4, 2019
Contributor
XhmikosR
left a comment
XhmikosR
left a comment
There was a problem hiding this comment.
There are a lot more but we'll be able to fix them later when we have automated testing in place :)
celyes
approved these changes
Sep 4, 2019
|
@XhmikosR would you be so kind to share anything on how to automate the change from http to https throughout the whole website? Redirects are annoying.. |
Contributor
|
@rokaslit6 I'm not done yet, I still need to first have a working patch for 404 pages. I just need to figure out a way to make the check not take 2 hours, and it's not easy so far :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There're some URLs that starts with 'https', change them together.